Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove requirement for smtp section #3405

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Jul 31, 2023

Fixes #3392

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3405 (dc44854) into master (e3fcf0c) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head dc44854 differs from pull request most recent head 4b109b0. Consider uploading reports for the commit 4b109b0 to get more accurate results

@@           Coverage Diff           @@
##           master    #3405   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files         327      327           
  Lines       21364    21364           
=======================================
  Hits        16669    16669           
  Misses       3457     3457           
  Partials     1238     1238           

@jonas-jonas jonas-jonas self-assigned this Jul 31, 2023
@aeneasr aeneasr merged commit 59a3f14 into master Jul 31, 2023
29 checks passed
@aeneasr aeneasr deleted the jonas-jonas/removeRequiredSMTPSection branch July 31, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Courier always expects smtp values, even when using http delivery strategy
2 participants